Update the snapshot helper to be able to save raw json and parsed and validated response struct #206
+180
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validated response struct. adapted the replacer function to support multiline skips for maps or slices
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 62.86% 63.25% +0.39%
==========================================
Files 78 78
Lines 6053 6088 +35
==========================================
+ Hits 3805 3851 +46
+ Misses 1635 1624 -11
Partials 613 613
☔ View full report in Codecov by Sentry. |
…rter into mwr/json-snapshots
anjankow
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Save function to the snapshot helper which snapshots the (prettified) raw json response body first and then calls
ParseResponseAndValidateand snapshots the parsed and validated struct.Also enhanced the replacer when using
Skipby supporting multiline skips for maps or slices.